Skip to content

Remove unnecessary select for removing an auth code grant #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Apr 21, 2025

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@dopry
Copy link
Contributor

dopry commented May 19, 2025

What's the upside to this change?

@q0w
Copy link
Contributor Author

q0w commented May 19, 2025

-1 SQL query. Instead of fetching first and then deleting, you can just delete. .delete() returns the number of deleted rows, so you can still raise an error if nothing was deleted.

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (e34819a) to head (e488f89).
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
- Coverage   97.41%   97.01%   -0.40%     
==========================================
  Files          34       34              
  Lines        2164     2212      +48     
==========================================
+ Hits         2108     2146      +38     
- Misses         56       66      +10     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dopry
Copy link
Contributor

dopry commented Jun 3, 2025

@n2ygk this looks good to me. Do you have any reservations about merging?

@n2ygk
Copy link
Member

n2ygk commented Jun 3, 2025

@n2ygk this looks good to me. Do you have any reservations about merging?

@dopry I'd like to see the checklist completed (author name in AUTHORS, etc.). Also needs to be rebased. Otherwise I'm good with you merging it.

@q0w
Copy link
Contributor Author

q0w commented Jun 3, 2025

unit-test added

There is an already existing test for that

documentation updated

Not needed

CHANGELOG.md updated (only for user relevant changes)

Not needed

@dopry dopry merged commit 2f2b7f0 into jazzband:master Jun 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants