-
-
Notifications
You must be signed in to change notification settings - Fork 809
Remove unnecessary select for removing an auth code grant #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What's the upside to this change? |
-1 SQL query. Instead of fetching first and then deleting, you can just delete. .delete() returns the number of deleted rows, so you can still raise an error if nothing was deleted. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
- Coverage 97.41% 97.01% -0.40%
==========================================
Files 34 34
Lines 2164 2212 +48
==========================================
+ Hits 2108 2146 +38
- Misses 56 66 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@n2ygk this looks good to me. Do you have any reservations about merging? |
There is an already existing test for that
Not needed
Not needed |
Description of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS