Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure eav.register() Maintains Manager Order #595

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Jun 23, 2024

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • [] I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix

Other Information

This addresses an issue where the order of managers in the model's _meta was not maintained correctly when adding a new EntityManager. The creation_counter of the new manager is set to ensure it maintains the correct order relative to existing managers.

I discovered the issue when attempting add a new manager, yet Django wanted to make migrations to the managers and the default manager wasn't available in the a migration RunPython call.

@Dresdn Dresdn merged commit 6585010 into jazzband:master Jun 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant