Ensure eav.register() Maintains Manager Order #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm helping!
Checklist
CHANGELOG.md
Pull Request type
Please check the type of change your PR introduces:
Other Information
This addresses an issue where the order of managers in the model's
_meta
was not maintained correctly when adding a newEntityManager
. Thecreation_counter
of the new manager is set to ensure it maintains the correct order relative to existing managers.I discovered the issue when attempting add a new manager, yet Django wanted to make migrations to the managers and the default manager wasn't available in the a migration
RunPython
call.