Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance BaseEntityAdmin #541

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Mar 6, 2024

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Closes #540

- Implement dynamic EAV fieldset rendering in admin forms, supporting the inclusion of EAV attributes alongside standard model fields.
- Introduce `eav_fieldset_title` and `eav_fieldset_description` to customize the display of EAV fields in the admin.
- Refactor `render_change_form` to dynamically assemble fieldsets, including a dedicated section for EAV attributes.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (84bfbf9) to head (dfacd67).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   90.98%   90.53%   -0.46%     
==========================================
  Files          32       32              
  Lines         854      866      +12     
  Branches      115      116       +1     
==========================================
+ Hits          777      784       +7     
- Misses         56       61       +5     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dresdn Dresdn merged commit d6af6a0 into jazzband:master Mar 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseEntityAdmin Ignores readonly_fields
1 participant