-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Django 5.0 and Python 3.12 to the testing #487
Conversation
Thank you @cclauss! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 32 32
Lines 854 854
Branches 115 115
=======================================
Hits 777 777
Misses 56 56
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Downstream PyYAML needs to be upgraded to |
Yes, and yaml/pyyaml#769 is still open but Py3.12 wheels are available. https://pypi.org/project/PyYAML/6.0.1/#files Let's run the tests on pyyaml 6.0.1 and if that fails, we can hold off on the Py3.12 upgrade and just focus on Dj5. |
@@ -70,7 +72,9 @@ build_command = "pip install poetry && poetry build" | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it, wemake-python-styleguide
should be upgraded to 0.18.0
as it'll pull in the updated version of bandit once released, but needs python to be 3.8.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using ruff yet? https://docs.astral.sh/ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny you say that, as that's 100% on my ToDo. I started a working branch a while ago, but yes, we absolutely should.
Please let me know if you want me to squash on my side or if you just |
I'll squash it - thank you for the help! |
I'm helping!
Checklist
CHANGELOG.md
Pull Request type
Please check the type of change your PR introduces:
Related issue(s)
Other Information