Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Django 5.0 and Python 3.12 to the testing #487

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 9, 2024

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Add Django 5.0 and Python 3.12 to the testing

Related issue(s)

Other Information

@Dresdn
Copy link
Contributor

Dresdn commented Jan 10, 2024

Thank you @cclauss!

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (141a274) 90.98% compared to head (de2d379) 90.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files          32       32           
  Lines         854      854           
  Branches      115      115           
=======================================
  Hits          777      777           
  Misses         56       56           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dresdn
Copy link
Contributor

Dresdn commented Jan 10, 2024

Downstream PyYAML needs to be upgraded to 6.0.1 to support Python 3.12.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 10, 2024

Yes, and yaml/pyyaml#769 is still open but Py3.12 wheels are available. https://pypi.org/project/PyYAML/6.0.1/#files

Let's run the tests on pyyaml 6.0.1 and if that fails, we can hold off on the Py3.12 upgrade and just focus on Dj5.

pyproject.toml Outdated Show resolved Hide resolved
@@ -70,7 +72,9 @@ build_command = "pip install poetry && poetry build"

[tool.poetry.dependencies]
python = "^3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it, wemake-python-styleguide should be upgraded to 0.18.0 as it'll pull in the updated version of bandit once released, but needs python to be 3.8.1.

Copy link
Contributor Author

@cclauss cclauss Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using ruff yet? https://docs.astral.sh/ruff

Copy link
Contributor

@Dresdn Dresdn Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny you say that, as that's 100% on my ToDo. I started a working branch a while ago, but yes, we absolutely should.

pyproject.toml Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor Author

cclauss commented Jan 10, 2024

Please let me know if you want me to squash on my side or if you just Squash & Merge.

@Dresdn
Copy link
Contributor

Dresdn commented Jan 10, 2024

I'll squash it - thank you for the help!

@Dresdn Dresdn merged commit 3ca27bb into jazzband:master Jan 10, 2024
18 checks passed
@cclauss cclauss deleted the patch-1 branch January 10, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants