Forward the request when saving the form

[felippem]

Hello. I would like to forward the request to the instance of ConstanceForm, when calling the save method. Help me understand if it is necessary to update any tests.

[felippem]

@Mogost @jezdez @Mogost Can you please review this?

[jezdez]

@felippem Yes, the tests need to be updated, but I'm also curious for the use case?

[codecov]

Codecov Report

Merging #499 (edbf1e3) into master (02c5fd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          16       16           
  Lines         600      600           
  Branches      120      120           
=======================================
  Hits          499      499           
  Misses         67       67           
  Partials       34       34           

Impacted Files	Coverage Δ
constance/admin.py	88.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[felippem]

@felippem Yes, the tests need to be updated, but I'm also curious for the use case?

@jezdez I'd like to get the request.user.has_perm when the form loads, after it's posted. I have a custom form, which inherits Constance's original implementation.

[felippem]

@felippem Yes, the tests need to be updated, but I'm also curious for the use case?

@jezdez I'd like to get the request.user.has_perm when the form loads, after it's posted. I have a custom form, which inherits Constance's original implementation.

Hi @jezdez ! Did you understand my use case?

[jezdez]

@felippem I get it now, but this is actually a regression, since there is a permission check in the ConstanceForm.__init__ method that is currently not run for POST requests since the request isn't passed. Since the tests don't fail, it seems as if this line of code isn't accurately tested. Please add/update a test case for this.

[jezdez]

This was an oversight in #393.

[felippem]

@felippem I get it now, but this is actually a regression, since there is a permission check in the ConstanceForm.__init__ method that is currently not run for POST requests since the request isn't passed. Since the tests don't fail, it seems as if this line of code isn't accurately tested. Please add/update a test case for this.

So I'll try to do that soon. Thanks for answering.

[felippem]

@felippem I get it now, but this is actually a regression, since there is a permission check in the ConstanceForm.__init__ method that is currently not run for POST requests since the request isn't passed. Since the tests don't fail, it seems as if this line of code isn't accurately tested. Please add/update a test case for this.

So I'll try to do that soon. Thanks for answering.

@jezdez Done. Can you review please?

[jezdez]

Thanks @felippem, this looks good to me. Would you mind adding an item to docs/changes.rst to note the regression fix?

[felippem]

Thank you @jezdez. Have an idea about the next release?

[camilonova]

Thank you

[felippem]

Hi, @camilonova! Do you have a date for the next release?