Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GitHub Actions workflow. #283

Merged
merged 15 commits into from
Nov 26, 2020
Merged

Initial GitHub Actions workflow. #283

merged 15 commits into from
Nov 26, 2020

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Nov 25, 2020

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

This contains a work-around for #266 until there is a real fix, e.g. via #271 etc.

No more mention of Travis CI in the codebase:

$ git grep -i travis
$

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #283 (6570e09) into master (50da341) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   81.83%   81.94%   +0.11%     
==========================================
  Files          18       18              
  Lines         490      493       +3     
==========================================
+ Hits          401      404       +3     
  Misses         89       89              
Impacted Files Coverage Δ
auditlog/models.py 82.22% <0.00%> (+0.19%) ⬆️
auditlog/middleware.py 68.42% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50da341...6570e09. Read the comment docs.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions!

README.md Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
auditlog_tests/tests.py Outdated Show resolved Hide resolved
jezdez and others added 5 commits November 26, 2020 08:23
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@jezdez jezdez merged commit 9100895 into master Nov 26, 2020
@jezdez jezdez deleted the gha branch November 26, 2020 09:45
@hugovk
Copy link
Member

hugovk commented Dec 2, 2020

I spotted the cron was still enabled at https://travis-ci.com/github/jazzband/django-auditlog / https://travis-ci.com/github/jazzband/django-auditlog/settings:

image

So I deleted it:

image

@jezdez
Copy link
Member Author

jezdez commented Dec 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants