Adding formats to configuration, closes #94 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapio
commented
Nov 30, 2022
| @@ -581,3 +581,9 @@ def rename_tag(self, old_tag, new_tag): | |||
|
|
|||
| self.frames.changed = True | |||
| self.save() | |||
|
|
|||
| def style(self = None, name = 'error', element = None): | |||
| if isinstance(self, Watson): | |||
There was a problem hiding this comment.
This is an hack, I should have probably commented it in the code. Here is the rationale.
Having self default to None is a way to have both (sort of) a class method (used in case the object has not yet been instantiated, for instance by exceptions in cli) and an instance method.
If called as Watson.style this will not attempt to look at the config property of the uninstantiated object; on the other hand, if watson is an instance of Watson, then watson.style will be able to access the configured formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
formatsconfiguration section that can contain configuration for colors (and other) used by click.style.