Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jellyfin. #1251

Merged
merged 3 commits into from
May 17, 2023
Merged

Add Jellyfin. #1251

merged 3 commits into from
May 17, 2023

Conversation

yslin1995
Copy link
Contributor

@yslin1995 yslin1995 commented May 16, 2023

Types of Changes

What types of changes does your PR introduce? Put an x in all boxes that apply

  • [x ] New addition to list

Proposed Changes

Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

  1. Add Jellyfin.

PR Checklist

Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] I have read the CONTRIBUTING guide
  • [ x] I have explained why this PR is important
  • [ x] I have added necessary documentation (if appropriate)

Add Jellyfin and IconChanger
README.md Outdated
* [Grayscale Mode](https://github.com/rkbhochalya/grayscale-mode) - An open source macOS app that lets you quickly toggle grayscale filter right from your menu bar or using a keyboard shortcut (⌥⌘G). [![Open-Source Software][OSS Icon]](https://github.com/rkbhochalya/grayscale-mode) ![Freeware][Freeware Icon]
* [IconChanger](https://github.com/underthestars-zhy/IconChanger) - Simply change your app's icon on macOS. Just a click. [![Open-Source Software][OSS Icon]](https://github.com/underthestars-zhy/IconChanger) ![Freeware][Freeware Icon]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lin-Youth Nice tool, it doesn't appear to be a desktop application.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a screenshot of the desktop app running on my mac below:
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the app download link for it

@Lin-Youth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lin-Youth There is no download link on the official website, which will confuse people, so I decided not to add it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove it, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Only Jellyfin added.

Delete an app without download link.
@yslin1995 yslin1995 changed the title Add Jellyfin and IconChanger apps. Add Jellyfin. May 17, 2023
@jaywcjlove jaywcjlove merged commit 43bb184 into jaywcjlove:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants