Skip to content

Add additional clickhouse database datetime functions #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025

Conversation

AndrewSpeed
Copy link
Contributor

@AndrewSpeed AndrewSpeed commented May 29, 2025

What changed?

Adds several of the clickhouse datetime functions, specifically:

resolves #124

Specifically, toStartOfMinute, toStartOfFiveMinutes, toStartOfTenminutes, toStartOfFifteenMinutes and toStartOfHour
@AndrewSpeed AndrewSpeed marked this pull request as ready for review May 29, 2025 13:22
@AndrewSpeed
Copy link
Contributor Author

@jayvynl I'm unable to reproduce these CI failures locally, I've tried several of the python and django versions and haven't encountered the same errors, even with CLICKHOUSE_VERSION=latest like is being used for the CI runs

@jayvynl
Copy link
Owner

jayvynl commented May 31, 2025

@jayvynl I'm unable to reproduce these CI failures locally, I've tried several of the python and django versions and haven't encountered the same errors, even with CLICKHOUSE_VERSION=latest like is being used for the CI runs

3969971854e9 Pull complete ,check if clickhouse docker image digest matches, there must be a change about the default user in recent clickhouse release , the ci failure is about clickhouse authentication.

@AndrewSpeed
Copy link
Contributor Author

I've added an explicit CLICKHOUSE_PASSWORD as suggested in this stackoverflow answer that it may resolve authentication failures between cluster nodes

@AndrewSpeed AndrewSpeed requested a review from jayvynl June 3, 2025 08:37
@AndrewSpeed
Copy link
Contributor Author

@jayvynl it looks like the last CI failure is a known issue with docker, a re-run may cause the test to pass

@jayvynl
Copy link
Owner

jayvynl commented Jun 3, 2025

@jayvynl it looks like the last CI failure is a known issue with docker, a re-run may cause the test to pass

No need, I will just merge. Thank you very much.

@jayvynl jayvynl merged commit 493b422 into jayvynl:main Jun 3, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for datetime toStartOf functions
2 participants