-
Notifications
You must be signed in to change notification settings - Fork 27
For a given query execution, allow data to be returned in columnar format and deserialized to numpy objects #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4434620
to
bd1c670
Compare
@jayvynl This is ready for review. Although it's failing on the My suspicion is that the I already have some tests created. I'll continue to improve the test coverage after you approve the overall implementation. |
Although I think Please update the tox.ini file to add numpy and pandas commands =
pip install pandas
# Use local clickhouse_backend package so that coverage works properly.
pip install -e .
coverage run tests/runtests.py --debug-sql {posargs} Please update document and changelog. |
@jayvynl The changes have been made:
The checks look good now, aside from running tests against the I wonder whether it'd be valuable to add the clickhouse version deployed in ClickHouse Cloud in the matrix. I can create PRs in the future to make sure the CI/CD pipeline config is updated whenever ClickHouse Cloud has deployed new ClickHouse versions. |
This PR will allow SQL query results to be returned in columns and to be deserialized to numpy objects, without affecting other queries that could run in the system (e.g. Database introspection queries, INSERT queries, etc.)
Relates:
columnar=True
attribute when using the DB API and deserialize results into numpy objects #119