flake8 3.0 includes per line noqa

[jayvdb]

This will at least make some parts of flake8-putty unnecessary, similar to spookylukey/flake8-respect-noqa#3

Should this plugin only support flake8 2.x and recommend that requests for similar functionality in flake8 3.x be requested as features for the main utility, at least until there is push back from the maintainers like there was in flake8 2.x.

[jayvdb]

The main features which would need re-implementing are line regex , and environment markers.
I think it is worth trying to implement them properly inside flake8 v3, or as an extension using a proper v3 style approach.

[The-Compiler]

What about per-file/directory ignores, is this something flake8 3.0 can already handle?

For example, I do this:

putty-ignore =
    tests/*/test_*.py : +D100,D101,D401    # (mostly some pytest magic flake8 doesn't understand)
    tests/unit/browser/webkit/http/test_content_disposition.py : +D400   # (docstrings from external source I don't want to deviate from)
    scripts/dev/ci/appveyor_install.py : +FI53  # (needs future import as it needs to be python 2 compatible)

[jayvdb]

@sigmavirus24, are there any features mentioned above that you would object to being in flake8 v3?

[sigmavirus24]

per-file/directory ignores are things I do not want in Flake8 3.0. putty would be a good place to keep them.

[jayvdb]

Ok.
Does the flake8 v3 api allow for customisations like that?

[sigmavirus24]

We don't allow you to replace the StyleGuide. You can register your own formatter to do that kind of thing though. This is all documented on flake8.pycqa.org. If the docs need to be improved, please let me know. I'm trying to drastically improve them given how awful 2.x's docs were.

[jayvdb]

Thanks. Good to know it is going to be easier in v3.

[sigmavirus24]

Eh, I'm starting to soften on this idea. We could target it for a Flake8 3.x release. I have an idea of how we might implement it too.

[JelteF]

Any work on this? I would like love to use the new flake8 for my project, but this is keeping me.

[jayvdb]

I am waiting for flake8 v3 to stablise, before using it in my own projects, and thus before I commit time to trying to make -putty work with v3, and definitely before I release a version that allows -putty to support v3.

Last time I tried it, it failed very badly: https://gitlab.com/pycqa/flake8/issues/205
I see another similarly fundamental problem has been raised: https://gitlab.com/pycqa/flake8/issues/209

If someone wants to do the leg work before me, I am ok with releasing a pre-release of -putty.

[JelteF]

Fair enough.Thanks for the useful plugin.

[lucaswiman]

@sigmavirus24

We don't allow you to replace the StyleGuide. You can register your own formatter to do that kind of thing though. This is all documented on flake8.pycqa.org. If the docs need to be improved, please let me know. I'm trying to drastically improve them given how awful 2.x's docs were.

I looked through the docs and the code, and it's clear how to use a formatter to keep errors from being outputted. However, there doesn't seem to be a way to have a formatter not count the error count recorded by the style guide. This means that even if you used putty to ignore errors , the exit status would still be nonzero. CI systems and git hooks depend on the exit status being correct, so I think it's still not possible to update update flake8-putty to be compatible with flake8 3+.