Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win32_NetworkAdapter: use PhysicalAdapter to check whether the NIC IsVirtual #292

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Win32_NetworkAdapter: use PhysicalAdapter to check whether the NIC IsVirtual #292

merged 1 commit into from
Nov 29, 2021

Conversation

lukashartl
Copy link
Contributor

@lukashartl lukashartl commented Nov 27, 2021 •
edited
Loading

This is my proposed fix for #291 .

Simple test with my windows pc, showing nic.Name and nic.IsVirtual:

Microsoft Kernel Debug Network Adapter                                                  true
VirtualBox Host-Only Network - VirtualBox Host-Only Ethernet Adapter                    false
Ethernet - Realtek Gaming GbE Family Controller                                         false
WAN Miniport (SSTP)                                                                     true
WAN Miniport (IKEv2)                                                                    true
WAN Miniport (L2TP)                                                                     true
WAN Miniport (PPTP)                                                                     true
WAN Miniport (PPPOE)                                                                    true
WAN Miniport (IP)                                                                       true
WAN Miniport (IPv6)                                                                     true
WAN Miniport (Network Monitor)                                                          true

fixes #291

@lukashartl
Win32_NetworkAdapter: use PhysicalAdapter to check whether the NIC Is…
63794b9 
…Virtual

Signed-off-by: Lukas Hartl <60550303+lukashartl@users.noreply.github.com>
jaypipes
jaypipes approved these changes Nov 29, 2021
View reviewed changes
Copy link
Owner

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much @lukashartl! :)

@jaypipes jaypipes added this to the v1.0.0 milestone Nov 29, 2021
@jaypipes jaypipes merged commit d0afaf8 into jaypipes:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

NIC on Windows has IsVirtual always set to false
2 participants
@lukashartl @jaypipes