Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch-to-buffer-other-window opens frame when 'split-width-threshold is nil #209

Closed
bretweinraub opened this issue Dec 9, 2016 · 4 comments
Labels

Comments

@bretweinraub
Copy link

Emacs 25.1

I removed nearly everything from my .emacs, to make sure it wasn't me.

I have this:

(require 'neotree)
(setq neo-smart-open t)
(define-key neotree-mode-map (kbd "i") #'neotree-enter-horizontal-split)
(define-key neotree-mode-map (kbd "I") #'neotree-enter-vertical-split)

;; i like horizontal splits because, that's the way Emacs was originally!!!!
(setq split-width-threshold nil)

so open neotree, make sure you have one other window open, and do C-x-4-b otherwise know as switch-to-buffer-other-window.

And it opens a new frame ....

@bretweinraub
Copy link
Author

For the moment, I've had to abandon neotree....

@aborn
Copy link
Collaborator

aborn commented Dec 14, 2016

Sorry for delay reply. This is a bug!

@aborn
Copy link
Collaborator

aborn commented Dec 15, 2016

This bug already fixed in cfef603 . Add flowing setting in your init file:
(setq split-window-preferred-function 'neotree-split-window-sensibly)

@aborn aborn closed this as completed Dec 15, 2016
@bretweinraub
Copy link
Author

Works for me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants