Code review: fix version drift, centralize constants, update documentation#147
Merged
jaypatrick merged 6 commits intomasterfrom Jan 13, 2026
Merged
Conversation
|
Version bumped: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
adblock-compiler | 4625967 | Jan 13 2026, 12:18 PM |
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update markdown files during code review
Code review: fix version drift, centralize constants, update documentation
Jan 13, 2026
Owner
|
@copilot Thank you |
Owner
|
@copilot Commit to branch and create pr |
Author
jaypatrick
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive code review identified version synchronization issues, scattered magic numbers, and stale documentation references.
Changes
Version Management
src/plugins/PluginSystem.ts: Replace hardcoded0.6.91withVERSIONconstant fromsrc/version.tsCentralized Configuration
src/downloader/ContentFetcher.ts: UseNETWORK_DEFAULTS.TIMEOUT_MSinstead of30000worker/worker.ts: ImportWORKER_DEFAULTSfor rate limiting, cache TTL, metrics windowDocumentation
README.md: Fix typo ("are are" → "are"), add missingConvertToAsciitransformation.github/copilot-instructions.md: Correct line width (100 → 180) to matchdeno.jsonCODE_REVIEW.md: Rewrite with current assessment, mark resolved issuesREVIEW_SUMMARY.md: New file documenting review findingsAssessment
Codebase verified as production-ready:
src/config/defaults.tsErrorUtilsanytypesNo critical issues remain.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.