make validatr conform to the html5 spec when form elements are disabled#16
Open
jonathansnell wants to merge 1 commit intojaymorrow:masterfrom
Open
make validatr conform to the html5 spec when form elements are disabled#16jonathansnell wants to merge 1 commit intojaymorrow:masterfrom
jonathansnell wants to merge 1 commit intojaymorrow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently validatr does not conform to the HTML5 for validation of form fields when some of those fields are disabled. See this section of the HTML5 specification:
http://www.w3.org/html/wg/drafts/html/master/forms.html#enabling-and-disabling-form-controls:-the-disabled-attribute
This pull request adds code to ensure that disabled elements are not checked for validity, allowing the form to be submitted.