-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow missing coverage via an environment variable #2
Conversation
Thanks for the contribution; I've got a lot going on at the moment but I hope to process this PR within the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not getting back to this sooner!
Firstly, we need to rebase this PR on the changes in master
branch.
The IGNORE_COVERAGE
environment variable name needs some consideration. "Ignoring" in regards to this package refers to ignoring regions of coverage that may or may not be uncovered, via ignore comments; it shows up as yellow/orange in the CLI report after tests pass. Someone that reads IGNORE_COVERAGE
might expect that it does what ignore comments do, and might assume that it would maybe make all files yellow/ignored. In fact, it doesn't ignore any of the files. The full coverage report happens as usual, all this environment variable does is prevent missing coverage from causing an error exit code.
Long name, but just an example of clearer semantics: TOLERATE_INCOMPLETE_COVERAGE
.
Ideally, we could find examples of similar environment variable names to perhaps align with existing ones. I tried searching around the docs for popular testing frameworks for 10 minutes and strangely couldn't find any, but surely they exist!
We also need to add tests.
we need to rebase - done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the ball rolling, and for your patience!
Published in v6.1.0 🚀 |
No description provided.