Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing coverage via an environment variable #2

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

vitaliytv
Copy link
Contributor

No description provided.

@jaydenseric
Copy link
Owner

Thanks for the contribution; I've got a lot going on at the moment but I hope to process this PR within the next few days.

Copy link
Owner

@jaydenseric jaydenseric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not getting back to this sooner!

Firstly, we need to rebase this PR on the changes in master branch.

The IGNORE_COVERAGE environment variable name needs some consideration. "Ignoring" in regards to this package refers to ignoring regions of coverage that may or may not be uncovered, via ignore comments; it shows up as yellow/orange in the CLI report after tests pass. Someone that reads IGNORE_COVERAGE might expect that it does what ignore comments do, and might assume that it would maybe make all files yellow/ignored. In fact, it doesn't ignore any of the files. The full coverage report happens as usual, all this environment variable does is prevent missing coverage from causing an error exit code.

Long name, but just an example of clearer semantics: TOLERATE_INCOMPLETE_COVERAGE.

Ideally, we could find examples of similar environment variable names to perhaps align with existing ones. I tried searching around the docs for popular testing frameworks for 10 minutes and strangely couldn't find any, but surely they exist!

We also need to add tests.

@vitaliytv
Copy link
Contributor Author

we need to rebase

we need to rebase - done
rename ENV - done
need to add tests - can you help me with this ?

@jaydenseric jaydenseric changed the title add IGNORE_COVERAGE env for only show coverage Allow missing coverage via an environment variable Feb 17, 2022
Copy link
Owner

@jaydenseric jaydenseric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the ball rolling, and for your patience!

@jaydenseric jaydenseric merged commit 2ec14bb into jaydenseric:master Feb 17, 2022
@jaydenseric
Copy link
Owner

Published in v6.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants