Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 14+ compatibility fix #297

Closed
wants to merge 3 commits into from
Closed

Node 14+ compatibility fix #297

wants to merge 3 commits into from

Commits on Oct 30, 2022

  1. Node 14+ compatibility fix

    This PR fix errors related to npm package `extract-file` imports that no longer works with recent version of node (at least v18.x.x and v19.x.x).
    It seems that `extract-file` npm package.json prevent node from importing directly from files within public directory.
    
    
    Here is the errors I got:
    > Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './public/extractFiles' is not defined by "exports" in [...]/node_modules/extract-files/package.json
    same goes for two other exports:
    > Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './public/isExtractableFile' is not defined by "exports" in [...]/node_modules/extract-files/package.json
    and
    > Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './public/ReactNativeFile' is not defined by "exports" in [...]/node_modules/extract-files/package.jsonx
    
    As `extract-file` index.js exports these directly I've just updated the imports.
    Freezystem authored Oct 30, 2022
    Configuration menu
    Copy the full SHA
    c3bbd4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89977ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d33ff87 View commit details
    Browse the repository at this point in the history