Allow multiple fixed-address entries and some other changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokens, and match cases where STRING used to match values w/ newlines with more exact token matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made some edits to the grammar definition in this package to get the parser working with my organization's old DHCP configuration files. I thought I'd send in a pull request in case you're interested in incorporating some, or all of the changes.
My main motivation was in allowing
fixed-addressvalues that referred to domain names in addition to IP addresses, and for multiple fixed-address values to be filled out per host. This led to some more edits to make things all work together and have tests pass.