[Mosaic GPU] Fix lowering of InitializeBarrierOp.
#33036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [#30545](#30545), we replaced the conversion from LLVM pointer to Memref with an unrealized conversion cast. We forgot to update the lowering of `InitializeBarrierOp` accordingly. The reason this is not a problem is because the result of `InitializeBarrierOp` is never used. We could drop the returned value from the op but this is orthogonal to this change. PiperOrigin-RevId: 826498254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU] Fix lowering of
InitializeBarrierOp.In #30545, we replaced the conversion from LLVM pointer to Memref with an unrealized conversion cast. We forgot to update the lowering of
InitializeBarrierOpaccordingly.The reason this is not a problem is because the result of
InitializeBarrierOpis never used. We could drop the returned value from the op but this is orthogonal to this change.