[MLIR] Fix construction of i1 attributes from numpy arrays and add tests.
#33027
+107
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests. This change fixes the construction of MLIR attributes from `numpy` arrays for a Boolean `dtype`. This happened when calling `jax.mlir.ir_attribute` and the problem occurred in `_numpy_array_attribute`: that function *first* bit-packed the Booleans and *then* determined the `dtype` from the result, which is `uint8` at that point rather than `bool`. The fix thus consists of a simple swapping of lines. Note that the virtually equivalent `_numpy_array_constant` already used the right order. The change also sets up tests for the MLIR component, which did not have any tests, and adds tests for some of the numpy-to-attribute conversions. PiperOrigin-RevId: 825955532
|
What do I have to do to have this PR reviewed? Since it was created by Copybara, I don't own the PR so I can't add reviewers... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MLIR] Fix construction of
i1attributes from numpy arrays and add tests.This change fixes the construction of MLIR attributes from
numpyarrays for a Booleandtype. This happened when callingjax.mlir.ir_attributeand the problem occurred in_numpy_array_attribute: that function first bit-packed the Booleans and then determined thedtypefrom the result, which isuint8at that point rather thanbool. The fix thus consists of a simple swapping of lines. Note that the virtually equivalent_numpy_array_constantalready used the right order.The change also sets up tests for the MLIR component, which did not have any tests, and adds tests for some of the numpy-to-attribute conversions.