Skip to content

Remove Cholesky forward compatibility path. #33007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −9
Open

Remove Cholesky forward compatibility path. #33007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions jax/_src/lax/linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,11 +881,6 @@ def _cholesky_cpu_lowering(ctx, operand):


def _cholesky_gpu_lowering(ctx, operand, *, target_name_prefix):
# TODO(phawkins): remove forward compat path after Nov 10, 2025.
# Remove also the `with config.export_ignore_forward_compatibility(True)`
# in `export_back_compat_test.py`.
if ctx.is_forward_compat():
return _cholesky_lowering(ctx, operand)
operand_aval, = ctx.avals_in
out_aval, = ctx.avals_out
batch_dims = operand_aval.shape[:-2]
Expand Down
5 changes: 1 addition & 4 deletions tests/export_back_compat_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,7 @@ def test_gpu_cholesky_solver_potrf(self, dtype_name="f32"):

info = cuda_cholesky_solver_potrf.data_2025_10_15[dtype_name]
data = self.load_testdata(info)
# TODO(necula): remove after Nov 10, 2025, when the forward compatibility
# window closes for the cholesky solver_potrf_ffi custom call.
with config.export_ignore_forward_compatibility(True):
self.run_one_test(func, data, rtol=rtol, atol=atol)
self.run_one_test(func, data, rtol=rtol, atol=atol)

@parameterized.named_parameters(
dict(testcase_name=f"_dtype={dtype_name}", dtype_name=dtype_name)
Expand Down
Loading