Preload the nvJitLink library installed by pip if available #28977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #28929, since
cuSPARSEandcuSOLVERdepend on thenvJitLinkviaRUNPATH, the incorrect version ofnvJitLinkmight be loaded whencuSPARSEorcuSOLVERis loaded ifLD_LIBRARY_PATHis set.The advice in #28929 was to make sure that
LD_LIBRARY_PATHis unset, but we can avoid this problem even whenLD_LIBRARY_PATHis set by preloading thenvJitLinklibrary from the pip package when it is available. In this case,cuSPARSEandcuSOLVERwill no longer try to load the wrong version, since the library is already available.I have manually checked that this fixes #28929 even when
LD_LIBRARY_PATHis set in a VM with multiple incompatible versions ofnvJitLinkavailable.