-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Skip generating source links for re-exported numpy functions in docs #28886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good! Would it be possible to mark NumPy re-exports on their summary pages as such? |
I'll let Jake comment on this one, but I agree that that would probably be a good idea! |
What summary pages do you have in mind? |
Mostly the For instance, even on this PR branch, the docs on |
I see - we have a couple options here:
I think (2) is probably the cleanest solution. |
Actually, there's also (4) deprecate I actually think this might be the clearest approach here. |
This sounds good to me, but I don't think it makes sense to make this change here. I'd say that it's still worth merging this PR regardless because we shouldn't ever generate these broken URLs! |
I'm happy to add these deprecations in a follow up PR! |
Fixes #28885
Some
jnp
functions (e.g.savez
) link to non-existent URLs when they are re-exported from numpy. We can skip generating these links when the source file doesn't live under thejax
source root.At this change, the source link no longer appears for
savez
, but it does forlinspace
, for example.