improve error message with when custom_vjp bwd rule produces wrong shape/dtype #28757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even the best of us can miss important error information, like noticing when shapes disagree. So let's make things better.
Before:
Traceback (most recent call last):
File "/usr/local/google/home/mattjj/packages/jax/rahul11.py", line 16, in
jax.grad(f)(3.14)
ValueError: Custom VJP bwd rule must produce an output with the same shape/dtypes as the args tuple of the primal function, but at output[0] the bwd rule produced an output of shape/dtype float32[10] corresponding to an input of shape/dtype float32[].
After (emphasis added):
Traceback (most recent call last):
File "/usr/local/google/home/mattjj/packages/jax/rahul11.py", line 16, in
jax.grad(f)(3.14)
ValueError: Custom VJP bwd rule must produce an output with the same shape/dtypes as the args tuple of the primal function, but at output[0] the bwd rule produced an output of shape/dtype float32[10] corresponding to an input of shape/dtype float32[], so the shapes do not match