Skip to content

chore: load py_library from rules_python #28358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

rickeylev
Copy link
Contributor

The native.py_* symbols are deprecated, newer versions of Bazel don't have them,
and newer versions of rules_python have mixed support for them.

Switch to loading them from rules_python instead, which are supported.

Copy link
Collaborator

@hawkinsp hawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me but let's see what the CI says.

(We're currently on a slightly older rules_python, but an update should land soon.)

@rickeylev
Copy link
Contributor Author

I think rules_python 0.39 is currently being used, which should be new enough.

If there's any issues, it's likely to be in the copybara transforms. native.py_* was eliminated within Google, so if native.py is showing up on github, then it would have to be a c copybara transform (or oss-specific file) that was doing it.

@hawkinsp
Copy link
Collaborator

I think rules_python 0.39 is currently being used, which should be new enough.

If there's any issues, it's likely to be in the copybara transforms. native.py_* was eliminated within Google, so if native.py is showing up on github, then it would have to be a c copybara transform (or oss-specific file) that was doing it.

Nope, we should be good. We don't transform this file's contents (and instead just point to a different file with the same API).

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Apr 28, 2025
@hawkinsp
Copy link
Collaborator

You want me to merge this? Mark it as non-draft?

@rickeylev rickeylev marked this pull request as ready for review April 28, 2025 20:53
@rickeylev
Copy link
Contributor Author

I've marked as ready for review. I had just left it in draft to lookup how to copybara transform it manually, but if that's a minor concern, then ready to merge

@copybara-service copybara-service bot merged commit 9fa4fb7 into jax-ml:main Apr 28, 2025
21 checks passed
@rickeylev rickeylev deleted the rm.native.py branch April 28, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants