Skip to content

Add docs for multi-process run in Kubernetes #28317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

yhtang
Copy link
Collaborator

@yhtang yhtang commented Apr 28, 2025

No description provided.

@yhtang yhtang changed the title Add docs and example for multi-process run in Kubernetes Add docs for multi-process run in Kubernetes Apr 28, 2025
@mattjj mattjj requested a review from mwhittaker April 30, 2025 17:15
Copy link
Collaborator

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you so much!

@yhtang
Copy link
Collaborator Author

yhtang commented May 2, 2025

This is awesome! Thank you so much!

You are welcome :)
I've address all the comments. Please let me know how it looks now.

@yhtang yhtang requested a review from mwhittaker May 2, 2025 21:52
Copy link
Collaborator

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect! Thanks so much. Would you mind squashing the commits, and then I can merge it in?

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels May 7, 2025
@yhtang
Copy link
Collaborator Author

yhtang commented May 7, 2025

It looks perfect! Thanks so much. Would you mind squashing the commits, and then I can merge it in?

Definitely. Doing now.

Co-authored-by: Michael Whittaker <mwhittaker@users.noreply.github.com>
@yhtang yhtang force-pushed the pr-add-k8s-docs branch from 18cb941 to 4a407bb Compare May 7, 2025 17:15
@yhtang
Copy link
Collaborator Author

yhtang commented May 7, 2025

It looks perfect! Thanks so much. Would you mind squashing the commits, and then I can merge it in?

Definitely. Doing now.

done 😄

@yhtang
Copy link
Collaborator Author

yhtang commented May 12, 2025

@mwhittaker could you please merge this PR when convenient?

@hawkinsp hawkinsp added pull ready Ready for copybara import and testing and removed pull ready Ready for copybara import and testing labels May 15, 2025
@copybara-service copybara-service bot merged commit 72f540e into jax-ml:main May 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants