Fix shard_map for primitives with multiple outputs and None specs #27720
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2810
approved these changes
Apr 3, 2025
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
@mattjj says the fix should be different which we just fixed for a different failure. But I'll let him link that |
|
Try this? i.e. out_rep should never be None. It should instead be replicated over all mesh axes.
|
|
@yashk2810 should we do |
mattjj
reviewed
Apr 4, 2025
Yeah good catch. It should only be manual names |
yashk2810
reviewed
Apr 4, 2025
yashk2810
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.