Move output path to be inside the wheel build command execution loop #25653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_708463366
branch
from
02a17dc to
6a9ef40
Compare
copybara-service
bot
changed the title
This was causing an issue when building multiple wheels in editable mode. i.e instead of wheels being stored as: ``` # jax-cuda12-pjrt 0.4.36.dev20241125 ./dist/jax-cuda-pjrt # jax-cuda12-plugin 0.4.36.dev20241125 ./dist/jax-cuda-plugin # jaxlib 0.4.36.dev20241125 ./dist/jaxlib ``` they were being stored as: ``` # jaxlib 0.4.36.dev20241125 ./dist/jaxlib # jax-cuda12-pjrt 0.4.36.dev20241125 ./dist/jaxlib/jax-cuda-pjrt # jax-cuda12-plugin 0.4.36.dev20241125 ./dist/jaxlib/jax-cuda-plugin ``` PiperOrigin-RevId: 708468522
copybara-service
bot
force-pushed
the
test_708463366
branch
from
6a9ef40 to
0159bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move output path to be inside the wheel build command execution loop
This was causing an issue when building multiple wheels in editable mode.
i.e instead of wheels being stored as:
they were being stored as: