[Mosaic:TPU] Fix bug after cl/707025084 #25540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_707183025
branch
5 times, most recently
from
1e662ba to
c5239b3
Compare
`tile_masks` was updated to use implicit, but we skipped the reshape for `tiles` Seems like there was even a bug before cl/707025084: `tile_masks` was never reshaped, so if the shape was 1D and a store mask was specified, there would be a mismatch in dimensions. PiperOrigin-RevId: 707368670
copybara-service
bot
force-pushed
the
test_707183025
branch
from
c5239b3 to
f9737b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic:TPU] Fix bug after cl/707025084
tile_maskswas updated to use implicit, but we skipped the reshape fortilesSeems like there was even a bug before cl/707025084:
tile_maskswas never reshaped, so if the shape was 1D and a store mask was specified, there would be a mismatch in dimensions.