Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated XLA GPU flags from docs. #25444

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

justinjfu
Copy link
Collaborator

@justinjfu justinjfu commented Dec 12, 2024

Several XLA GPU flags have been removed since the docs were last written. This PR removes:

Async collectives. Enabled by default now, see: openxla/xla@4298a06

Triton softmax fusion. Removed, see: openxla/xla@896e241

Addresses: #25430

@justinjfu justinjfu requested a review from mattjj December 12, 2024 17:56
@dfm
Copy link
Collaborator

dfm commented Dec 12, 2024

cc @Tixxx

@Tixxx
Copy link
Contributor

Tixxx commented Dec 12, 2024

Thanks for tagging me, wasn't aware of this when i opened(#25447). Mine also removes xla_gpu_enable_highest_priority_async_stream(enabled by default), can you add that change in your pr so i can just close mine.

@justinjfu
Copy link
Collaborator Author

Added xla_gpu_enable_highest_priority_async_stream.

Could I get one of your to review so we can get this merged in?

@Tixxx
Copy link
Contributor

Tixxx commented Dec 12, 2024

LGTM. But would need one of google folks to merge it.

Copy link
Collaborator

@dfm dfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Dec 13, 2024
@copybara-service copybara-service bot merged commit 99b390c into jax-ml:main Dec 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants