-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing test cases when JAX_ENABLE_X64=1
in the Bazel CPU build
#25443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_705532394
branch
from
December 12, 2024 18:15
e2329dc
to
43f2c53
Compare
copybara-service
bot
changed the title
Disable JAX_ENABLE_X64=1 build
Disable failing tests in the Dec 12, 2024
JAX_ENABLE_X64=1
Bazel CPU build
copybara-service
bot
force-pushed
the
test_705532394
branch
4 times, most recently
from
December 12, 2024 21:25
bf66172
to
b601642
Compare
copybara-service
bot
changed the title
Disable failing tests in the
Disable failing test cases when Dec 12, 2024
JAX_ENABLE_X64=1
Bazel CPU buildJAX_ENABLE_X64=1
in the Bazel CPU build
copybara-service
bot
force-pushed
the
test_705532394
branch
from
December 12, 2024 22:29
b601642
to
9a9cbc0
Compare
…uild PiperOrigin-RevId: 705635799
copybara-service
bot
force-pushed
the
test_705532394
branch
from
December 12, 2024 22:41
9a9cbc0
to
ecc2673
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
The primitive autodiff tests for `lax.cosh` and `lax.cbrt` were disabled in #25443 because they were found to be flaky in some configurations. This change re-enables these tests with the following updates: 1. For `lax.cbrt`, we now test with random inputs offset from zero since the derivative of `cbrt` is steep at the origin. 2. For `lax.cosh`, we (further) relax the test tolerance for `complex64` types. PiperOrigin-RevId: 706751360
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
The primitive autodiff tests for `lax.cosh` and `lax.cbrt` were disabled in #25443 because they were found to be flaky in some configurations. This change re-enables these tests with the following updates: 1. For `lax.cbrt`, we now test with random inputs offset from zero since the derivative of `cbrt` is steep at the origin. 2. For `lax.cosh`, we (further) relax the test tolerance for `complex64` types. PiperOrigin-RevId: 706751360
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
The primitive autodiff tests for `lax.cosh` and `lax.cbrt` were disabled in #25443 because they were found to be flaky in some configurations. This change re-enables these tests with the following updates: 1. For `lax.cbrt`, we now test with random inputs offset from zero since the derivative of `cbrt` is steep at the origin. 2. For `lax.cosh`, we (further) relax the test tolerance for `complex64` types. PiperOrigin-RevId: 706758349
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
At `float16` precision, one LAX reduction test was found to be flaky, and disabled in #25443. This change re-enables that test with a slightly relaxed tolerance instead. PiperOrigin-RevId: 706763871
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
At `float16` precision, one LAX reduction test was found to be flaky, and disabled in #25443. This change re-enables that test with a slightly relaxed tolerance instead. PiperOrigin-RevId: 706763871
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
At `float16` precision, one LAX reduction test was found to be flaky, and disabled in #25443. This change re-enables that test with a slightly relaxed tolerance instead. PiperOrigin-RevId: 706771186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable failing test cases when
JAX_ENABLE_X64=1
in the Bazel CPU build