Delete jax/tools/colab_tpu.py #22401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? TPU Node architecture runtimes have been removed from Colab. This can now be fully removed.
|
Thanks for this! Just to confirm, the V1 TPU runtimes are gone for good from Colab now? |
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
Actually, on further reflection, I think it's premature to remove All that function does right now is raise an informative error; removing it will make it raise a less informative error. There's little to no downside to keeping it around for a few more releases while the Colab TPU change percolates. What do you think? |
|
Yep, it's gone forever. And I don't have any objection to leaving this in. Up to you when you want to delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? TPU Node architecture TPU runtimes have been removed from Colab.
setup_tpuonly makes sense for very old versions of JAX on TPU Node architecture runtimes. In recent times, this function has only existed for the sake of warning people away from using this function on TPU VMs when it's unnecessary. Now that we're 100% on TPU VMs, we can just remove this. If folks have ancient TPU Node notebooks, they'll get an import error once this is removed, which seems fine to me, because 1. people have had quite some time to migrate over to TPU VM backends and 2. the vast majority of the existing notebooks have been migrated over to TPU VMs, so the impact should be low. Let me know if you have any objections.