Simplify Jaxpr: remove the bound_subjaxpr field, all subjaxprs are in… #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
approved these changes
Feb 11, 2020
… params. The goal is to make the Jaxpr language more uniform: all higher-order primitives carry sub-Jaxprs that are part of the parameters, and they are all called xxx_jaxpr. As a side-effect, some code is simplified (e.g., the code that searches for sub-jaxprs). For now the code assumes that all the `call` (final-style) primitives carry exactly one subjaxpr with the parameter name `call_jaxpr`. These primitives are still processed differently in the internal code, but there is no reason any external consumer of a Jaxpr needs to know this.
gnecula
force-pushed
the
simple_jaxpr2
branch
from
ba6843d to
20f9230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… params.
The goal is to make the Jaxpr language more uniform: all higher-order
primitives carry sub-Jaxprs that are part of the parameters, and they
are all called xxx_jaxpr. As a side-effect, some code is simplified
(e.g., the code that searches for sub-jaxprs).
For now the code assumes that all the
call(final-style) primitivescarry exactly one subjaxpr with the parameter name
call_jaxpr. Theseprimitives are still processed differently in the internal code, but
there is no reason any external consumer of a Jaxpr needs to know this.