Add Open MPI automatic distributed initialization #13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlcambier
reviewed
Jan 10, 2023
skye
requested changes
Jan 10, 2023
There was a problem hiding this comment.
LGTM overall, just a few comments + I like @nvlcambier's clarification ideas
nvcastet
requested review from
nvlcambier and
skye
and removed request for
nvlcambier
nvcastet
force-pushed
the
add_ompi_init
branch
from
da0e38e to
e849bf1
Compare
nvlcambier
approved these changes
Jan 11, 2023
google-ml-butler
bot
added
kokoro:force-run
pull ready
nvcastet
force-pushed
the
add_ompi_init
branch
from
e849bf1 to
532bae9
Compare
skye
requested changes
Jan 11, 2023
nvcastet
force-pushed
the
add_ompi_init
branch
from
532bae9 to
18ee348
Compare
nvcastet
force-pushed
the
add_ompi_init
branch
from
18ee348 to
b86030d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let you initialize JAX simply with
jax.distributed.initialize()when launching processes viampirun/mpiexec.