Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getAttribute fallback method #667

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Fix getAttribute fallback method #667

merged 2 commits into from
Nov 21, 2020

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Jan 8, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #667 (d4d2675) into master (c8dc33d) will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   94.62%   94.74%   +0.11%     
==========================================
  Files          19       19              
  Lines         800      799       -1     
  Branches      188      187       -1     
==========================================
  Hits          757      757              
+ Misses         30       29       -1     
  Partials       13       13              
Impacted Files Coverage Δ
src/utils/get-attribute.js 90.00% <66.66%> (ø)
src/pagination.js 91.93% <0.00%> (-0.26%) ⬇️
src/sort.js 96.92% <0.00%> (ø)
src/parse.js 100.00% <0.00%> (ø)
src/filter.js 100.00% <0.00%> (ø)
src/search.js 96.00% <0.00%> (ø)
src/templater.js 100.00% <0.00%> (ø)
src/utils/fuzzy.js 98.33% <0.00%> (ø)
src/fuzzy-search.js 100.00% <0.00%> (ø)
src/index.js 99.39% <0.00%> (+0.60%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8dc33d...750be59. Read the comment docs.

@javve javve merged commit 4e7f74d into javve:master Nov 21, 2020
@javve
Copy link
Owner

javve commented Nov 21, 2020

Thanks!

@boidolr boidolr deleted the fix_attribute_access branch November 22, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants