Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse iteration indices #637

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Reuse iteration indices #637

merged 2 commits into from
Nov 21, 2020

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Dec 22, 2018

Most loops in the library already do that anyway - this PR is updating the remaining ones.

@codecov-io
Copy link

Codecov Report

Merging #637 into master will not change coverage.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files          19       19           
  Lines         799      799           
  Branches      187      187           
=======================================
  Hits          757      757           
  Misses         29       29           
  Partials       13       13
Impacted Files Coverage Δ
src/utils/index-of.js 50% <0%> (ø) ⬆️
src/utils/to-array.js 100% <100%> (ø) ⬆️
src/utils/fuzzy.js 98.33% <100%> (ø) ⬆️
src/utils/events.js 75% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52afe2d...34f1701. Read the comment docs.

@javve javve merged commit 3baee53 into javve:master Nov 21, 2020
@javve
Copy link
Owner

javve commented Nov 21, 2020

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants