To avoid some namespace issues in a local client #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 19 19
Lines 799 799
Branches 187 187
=======================================
Hits 757 757
Misses 29 29
Partials 13 13
Continue to review full report at Codecov.
|
|
Thanks a lot for your PR. The main fix was great but I'm not interested in the other additions unfortunately 😇 so I took you fix and added it myself here: d081551 A good tips for your next PR is to not include anything that is unrelated and to not include the dist-files. 🙌 Glad that you like List.js, I just released version 2.0.0 and have added bunch of fixes from PRs today <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the template module, I was seeing a ie11 js error where the local item variable is said to be a native function where in every other instance and browser, it was undefined. Added a check to verify that the item is a string before performing indexOf on it. Also, I added some gitignore files, an .nvmrc file, and made a few linting changes that I was seeing on
npx webpack. Thanks for an awesome library and I look forward to the next version.