Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding to list asynchronously #570

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Fix adding to list asynchronously #570

merged 2 commits into from
Nov 21, 2020

Conversation

ohjann
Copy link
Contributor

@ohjann ohjann commented Jan 4, 2018

Fixes #569

@javve
Copy link
Owner

javve commented Dec 16, 2018

Thanks for the PR, however, I'm not sure that I understand what the problem is? :/
Is it possible to show in a test?

@javve javve closed this Nov 21, 2020
@javve javve reopened this Nov 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #570 (30967fa) into master (572cc95) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          19       19           
  Lines         810      810           
  Branches      188      188           
=======================================
  Hits          766      766           
  Misses         31       31           
  Partials       13       13           
Impacted Files Coverage Δ
src/index.js 98.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572cc95...30967fa. Read the comment docs.

javve added a commit that referenced this pull request Nov 21, 2020
@javve javve merged commit 21b0cad into javve:master Nov 21, 2020
@javve
Copy link
Owner

javve commented Nov 21, 2020

Ahhh, now I get it!
I added a test to confirm this as well: 000150a

Thanks!

@ohjann
Copy link
Contributor Author

ohjann commented Nov 23, 2020

@javve sorry should've provided more context two years ago lol

@ohjann ohjann deleted the fix-async-add branch November 23, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronous adding to list empties the input array
3 participants