Cleanup and Make Dependent on RFLink Cover#3
Open
shbatm wants to merge 1 commit intojavicalle:masterfrom
Open
Conversation
General code cleanup per HA Standards Make RTS Cover Device class inherit from RFLink cover to prevent need for importing twice.
Owner
|
@shbatm my sincere apologies for not giving you any feedback to the PR, but until now I have not been aware that I was here. I'm very sorry. I promise to review your comments and suggestions as soon as I have a moment to review them. |
Author
|
No worries. I know how it goes. I was using this version for a little over a year until I moved, it was working well. I haven't checked it against the newest HA since my RFLink is still in a box... |
javicalle
referenced
this pull request
May 29, 2021
Add version to the manifest file to acomplish with the HA custom_components requirements. Also add myself as codeowner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to share this back -- I appreciate the code base and all the work you've done on it! I went through and did some general code cleanup per HA Standards (Black, isort, etc.)
I also made some minor tweaks which I've been using for a couple months:
rflinkmodule twice.Don't worry if you don't want to use any of this; like I said, I just wanted to share back the tweaks I've made for my use case.