Skip to content

Comments

fix(ui): require save button for provider reorder and extend cache size range#321

Merged
javi11 merged 1 commit intomainfrom
session-436537
Feb 24, 2026
Merged

fix(ui): require save button for provider reorder and extend cache size range#321
javi11 merged 1 commit intomainfrom
session-436537

Conversation

@javi11
Copy link
Owner

@javi11 javi11 commented Feb 24, 2026

Summary

  • Provider reorder now requires Save: Drag-and-drop sorting previously auto-saved to the backend immediately. It now updates local state only and shows the "Unsaved Changes" banner, requiring the user to click Save Changes — consistent with toggling enabled/disabled or editing other provider fields.
  • Fix index bug: handleDrop was looking up indices in config.providers but splicing from formData, which could produce wrong results after multiple reorders without saving. Now uses formData indices consistently.
  • Remove reordering overlay: The "Reordering…" loading overlay and disabled-drag guards are no longer needed since the save is deferred.
  • Extend cache size slider: Max max_size_gb increased from 200 → 1000 GB with updated tick marks (250 / 500 / 750 / 1000).

Test plan

  • Drag providers to reorder — "Unsaved Changes" banner appears, no API call fired
  • Click Save Changes — order is persisted correctly
  • Toggle provider enabled/disabled — still shows unsaved changes and saves on button click
  • Discard changes by navigating away and back — order reverts to saved state
  • Cache size slider goes up to 1000 GB

🤖 Generated with Claude Code

…ze range

- Remove auto-save on drag-and-drop reorder; reordering now marks unsaved
  changes and requires the user to click Save Changes, consistent with
  other provider field edits
- Fix index lookup in handleDrop to use formData instead of config.providers
- Remove isReordering overlay and associated disabled-drag guards
- Extend streaming cache max_size_gb slider range from 200 → 1000 GB

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@javi11 javi11 merged commit bb55c4c into main Feb 24, 2026
1 check passed
@javi11 javi11 deleted the session-436537 branch February 24, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant