Conversation
Guard rclone VFS notification calls with a mount type check so that notifyRcloneVFS, NotifyVFS, and RefreshMountPathIfNeeded return early when mount_type is fuse or none. Previously, a stale non-nil rclone client could trigger RC calls that fail with "provider altmount not mounted" noise when running the internal FUSE mount. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifyRcloneVFS(internal/health/checker.go) to return early whenmount_typeis notrcloneorrclone_externalNotifyVFSandRefreshMountPathIfNeeded(internal/importer/postprocessor/vfs_notifier.go)cfg := hc.configGetter()call innotifyRcloneVFSto avoid a redundant second call inside the goroutineProblem
When using
mount_type: fuse, the app still attempted to notify rclone VFS after health checks, producing repeated errors:The rclone client was non-nil from a prior configuration (or initial wiring) but no rclone provider was registered, causing every RC call to fail.
Test plan
mount_type: fuse— no "Failed to notify rclone VFS" errors in logsmount_type: rclone— VFS refresh calls still happen (no regression)mount_type: rclone_external— VFS refresh calls still happen🤖 Generated with Claude Code