fix(health/arrs): improve health check scheduling and arrs integration#188
Merged
javi11 merged 6 commits intojavi11:mainfrom Dec 31, 2025
Merged
Conversation
refactor(health): remove dead code and fix Go anti-patterns (javi11#179)
Previously, the health repair process would fail if 'health.library_dir' was not configured, even though it was only used for logging in the Sonarr rescan logic. This change makes it optional, preventing repair failures for users with default configurations.
… 'origin/fix/sonarr-library-dir-optional'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces improvements to the health check scheduling system and fixes a configuration requirement for Sonarr integration.
Changes
Health Check System
GetUnhealthyFilesquery to include files marked ashealthyif theirscheduled_check_attime has passed. This enables the intended tiered scheduling strategy (aggressive -> daily -> normal) to function effectively, ensuring long-term validation of file retention.scheduled_check_at = datetime('now', '+1 hour')) when updating status torepair_triggered. This prevents rapid retry loops when repairs fail.Arrs Integration
triggerSonarrRescanByPathto treatHealth.LibraryDiras optional. Previously, missing this configuration would cause the repair process to error out. It now gracefully handles the missing config by falling back to other path resolution methods.Code Cleanup
sync.WaitGroupfield ininternal/importer/service.go.