Adding limit order support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAUTION: this was not testing on real market. I have modified the code to accept buy/sell orders with these parameters instrument,amount,price,time. This has been tested using backtrade.coffee only and seems to work (used this code https://cryptotrader.org/backtests/h26RZg8yWbt7rWayD , and enabled limit order feature to check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUTION: this was not tested on real markets.
I have modified the code to accept buy/sell orders with these parameters instrument,amount,price,time.
This has been tested using backtrade.coffee only and seems to work (used this code https://cryptotrader.org/backtests/h26RZg8yWbt7rWayD , and enabled limit order feature to check)