Fix regression in isObject (crashed w/ null values). #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing a column that has null values crashes in the latest version of danfojs, e.g for a dataframe:
df = DataFrame([{b: 5}, {a: 12, b:3}, {b:2}])Accessing
df["a"]would crash onisObjectlooking for a constructor for the null value.It's odd because I found a previous pull request fixing this:
#208
Not sure why this regression was introduced.
I also tried adding a test to catch such regressions in the future but noticed all columns' tests are commented out in:
tests/core/frame.jsIs that a temporary measure? Having all of those commented out might let such errors slip in in future releases.