Skip to content

Update Config Value #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
risenW merged 2 commits into from
Apr 25, 2021
Merged

Update Config Value #189

risenW merged 2 commits into from
Apr 25, 2021

Conversation

@adithyaakrishna
Copy link
Contributor

@adithyaakrishna adithyaakrishna commented Apr 25, 2021

Signed-off-by: Adithya Krishna aadithya794@gmail.com

This PR Fixes #188

@adithyaakrishna
Update Config Value
2df311f 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@risenW risenW self-requested a review April 25, 2021 14:20
risenW
risenW requested changes Apr 25, 2021
View reviewed changes
@adithyaakrishna
Copy link
Contributor Author

adithyaakrishna commented Apr 25, 2021

@risenW Is it possible if I can fix another issue in the same PR?
#77

As both of them are in the same files

@adithyaakrishna
Made Requested Changes
d26100a 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna adithyaakrishna requested a review from risenW April 25, 2021 14:41
@risenW
Copy link
Member

risenW commented Apr 25, 2021

@risenW Is it possible if I can fix another issue in the same PR?
#77

As both of them are in the same files

Sure, you can do it. I see you did it already 👍

@risenW risenW merged commit dae90d8 into javascriptdata:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risenW risenW risenW approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Read config value from x variable instead of y

2 participants

@adithyaakrishna @risenW