1-js/03-code-quality/05-testing-mocha- review #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sted 피동형 수정 호응 구조 수정 어감 수정
1-js/01-An Introduction/2-Manuals and specifications 리뷰 changes requ…
피동형 수정, 호응 구조 수정, 어감 수정, markdown 수정
1-js/03-code-quality/05-testing-mocha- review
|
|
JuYeong0413
reviewed
Oct 11, 2019
|
|
||
| 그런데 이렇게 수동으로 코드를 "재실행"하는 건 상당히 불완전합니다. | ||
| 하지만 이러한 수동 "재실행"은 불완전합니다. |
There was a problem hiding this comment.
'재실행'으로 바꾸는 건 어떨까요? #245
|
매뉴얼과 명세서 부분 커밋이 함께 올라와 있는데, PR을 따로 작성해주시기 바랍니다. 😃 |
|
브랜치를 나눠서 작업하는 연습을 하셔야 할 것 같습니다. |
|
아하 네네 한번에 커밋하는 습관이 있어서 저도모르게 일괄로 올려버렸네요 ㅠㅠ |
|
주제별로 브랜치 분리하여 작업 부탁드립니다. 소스 최신으로 업데이트하셔야할거예요 #333 위 리뷰 먼저 반영하려 합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
피동형 수정, 호응 구조 수정, 어감 수정, markdown 수정