Skip to content

add links #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2022
Merged

add links #3227

merged 7 commits into from
Nov 13, 2022

Conversation

Rnbsov
Copy link
Contributor

@Rnbsov Rnbsov commented Oct 8, 2022

No description provided.

@joaquinelio
Copy link
Member

mdn: markdn worked nicely years ago,
now, if mdn is unstranslated, leads to page not found.
i prefer to leave full English path, easier for translators (me) to check & change

@iliakan
Copy link
Member

iliakan commented Oct 8, 2022

@joaquinelio I guess we should ditch mdn://, replace it everywhere with long links to MDN?

@joaquinelio
Copy link
Member

Not pretty

image

well... "GOOD NEWS!" The user gets the link.
Not that enthusiastic news.

@joaquinelio
Copy link
Member

joaquinelio commented Oct 8, 2022

Yes.

  1. I cant do an easy replace mdn: ---> http...
    With Full path, I can check just from the editor or github site

  2. Not that bad if you leave Eng
    image

  3. The best: Once inside MDN, with the previous scroll youll leave your frustration to MDN.

@Rnbsov
Copy link
Contributor Author

Rnbsov commented Oct 17, 2022

Sooo, should I replace every mdn: with long ones?

@iliakan
Copy link
Member

iliakan commented Oct 17, 2022

  1. The best: Once inside MDN, with the previous scroll youll leave your frustration to MDN.

What's the 3rd variant? ;)

@iliakan
Copy link
Member

iliakan commented Oct 18, 2022

ping @joaquinelio

@joaquinelio
Copy link
Member

sorry... grammar again
and the mad old man I'm growing inside me was just kidding
they weren't variants, they were the enumeration of advantages full path gives when

no MDN transl is available

  1. !!!!!!!!!!!!!!!
    MDN: User is frustrated because javascript.info leads to 404.
    FULL: User is frustrated because MDN doesn't show his/her language.

so, don't take me always too seriously.
Still useful anyway.

@iliakan
Copy link
Member

iliakan commented Nov 13, 2022

Guess, the only clean way is to replace mdn: with full urls.

@iliakan iliakan merged commit fe3d781 into javascript-tutorial:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants