Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generators #57

Merged
merged 32 commits into from
Jun 6, 2020
Merged

Generators #57

merged 32 commits into from
Jun 6, 2020

Conversation

msisaifu
Copy link
Contributor

@msisaifu msisaifu commented May 9, 2020

I try to translate the Generators chapter. It's my first translation. Let me know if anything wrong.

Thanks :)

@javascript-translate-bot javascript-translate-bot requested a review from a team May 9, 2020 20:17
@iliakan iliakan mentioned this pull request May 9, 2020
Open
@CLAassistant
Copy link

CLAassistant commented May 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ahamed
ahamed reviewed May 10, 2020
View reviewed changes
Copy link
Contributor

@ahamed ahamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, with some typoes, I've given some suggestions. You can approve of them.

1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/solution.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/article.md Outdated
@@ -281,7 +284,7 @@ alert(str); // 0..9A..Za..z

The `yield*` directive *delegates* the execution to another generator. This term means that `yield* gen` iterates over the generator `gen` and transparently forwards its yields outside. As if the values were yielded by the outer generator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should translate this too.

1-js/12-generators-iterators/1-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/1-generators/article.md Outdated Show resolved Hide resolved
msisaifu and others added 20 commits May 10, 2020 23:20
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
12516dd 
…erator/solution.md

Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
761ac23 
…erator/task.md

Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
0847ca5 
…erator/task.md

Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
7a3be5e 
…erator/task.md

Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
e57fead 
…erator/task.md

Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
104ac43 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
63a7b31 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
6d4143b 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
f497c8b 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
98213d0 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
82074a3 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
83eb7b0 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
1199a7c 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
c175196 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
cfde4ec 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
26fe5c6 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
fff3e51 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
63cc866 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
b69e23b 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu @ahamed
Update 1-js/12-generators-iterators/1-generators/article.md
40962a3 
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
@msisaifu
Copy link
Contributor Author

Here, with some typoes, I've given some suggestions. You can approve of them.

thanks, approved :)

jaamaalxyz
jaamaalxyz requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

সামান্য কিছু চেঞ্জ আছে। খুব ভালো হয়েছে। চেঞ্জ গুলো কমপ্লিট করে ./done লিখে কমেন্ট করুন।

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

msisaifu and others added 7 commits June 6, 2020 23:57
@msisaifu
Update 1-js/12-generators-iterators/1-generators/article.md
d6e3723 
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/article.md
09cc415 
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/article.md
1ea17ee 
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/article.md
f8cdbc5 
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/article.md
c1b7cac 
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
98783f8 
…erator/task.md

Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Update 1-js/12-generators-iterators/1-generators/01-pseudo-random-gen…
4a77b3a 
…erator/solution.md

Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
@msisaifu
Copy link
Contributor Author

msisaifu commented Jun 6, 2020

done

@jaamaalxyz jaamaalxyz self-requested a review June 6, 2020 19:15
jaamaalxyz
jaamaalxyz approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for nice contribution. I hope we will get more contributions from you soon.

@jaamaalxyz jaamaalxyz merged commit d18b2dd into javascript-tutorial:master Jun 6, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahamed ahamed ahamed left review comments

@jaamaalxyz jaamaalxyz jaamaalxyz approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msisaifu @CLAassistant @javascript-translate-bot @ahamed @jaamaalxyz