Use StackWalker instread of sun.misc.SharedSecrets

[gayanW]

Use StackWalking API instead of the non-standard sun.misc.SharedSecrets API to access caller information.

This fixes errors:

[javac]   error: cannot find symbol
[javac]   symbol:   class SharedSecrets
[javac]   location: package sun.misc

[javac]   error: cannot find symbol
[javac]   symbol:   class JavaLangAccess
[javac]   location: class HashedAllocationContext

Fixes: #22

[gayanW]

@cyrille-artho is that ok that we use the == instead of equals()?

[cyrille-artho]

Hi, Whether String s1.equals(Strings s2) implies s1 == s2 depends on the context. If both sides are string constants, or interned strings, they indeed share the same reference. If you're not sure, it's of course safer to use equals().

…

On Wed, May 2, 2018 at 10:43 AM, Gayan Weerakutti ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/main/gov/nasa/jpf/vm/HashedAllocationContext.java <#24 (comment)> : > @@ -105,24 +109,24 @@ static int mixinJPFStack (int h) { // note that it is not advisable to mixin more than the immediate newX() caller since // this would create state leaks for allocations that are triggered by SUT threads and // have different native paths (e.g. Class object creation caused by different SUT thread context) - - StackTraceElement e = JLA.getStackTraceElement(throwable, 4); // see note below regarding fixed call depth fragility - // <2do> this sucks - MJIEnv.newObject/newArray/newString are used from a gazillion of places that might not differ in SUT state - if (e.getClassName() == ENV_CLSNAME && e.getMethodName().startsWith("new")){ @cyrille-artho <https://github.com/cyrille-artho> is that ok that we use the == instead of equals()? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG9eR9bbpYpcB4aOLbBJkRWhIMR9T6ydks5tuXG3gaJpZM4TvELs> .

-- Regards, Cyrille Artho