Update JVMClassFileContainer#getClassURL to comply with Module System #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e02daf as it is just a workaround to load model classes from jpf-classes.jar JPF is still unable to resove classes from other jars, hence reverting it.
The path returned from JVMClassFileContainer#getClassURL does not include the module name. This fixes it. Before: /path/to/container/java/lang/Object.class After: /path/to/container/java.base/java/lang/Object.class
JVMClassFileContainer#getClassEntryURL is introudced in 5647907
JVMClassFileContainer#getClassEntryURL is introudced in 5647907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates JVMClassFileContainer#getClassURL to comply with the URI structure used in the new Java Module System.
This is related to the issue #50 which is about JPF failing to load model classes from jpf-classes.jar due to different URI structure of the .class files being introuduced in Java Module System. The previous workaround introudced by the PR #51 is specifically for the jpf-classes.jar. JPF will still fail to locate classes from the other jar files.
Thus this reverts it. And make a implementation changes to JVMClassFileContainer#getClassURL which is JPF's universal container for holding Java class files.